distsql: tiny refactor to make the code more robust #10557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
component/coprocessor
type/enhancement
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10557 +/- ##
================================================
- Coverage 77.3469% 77.3222% -0.0247%
================================================
Files 413 413
Lines 87273 87275 +2
================================================
- Hits 67503 67483 -20
- Misses 14592 14605 +13
- Partials 5178 5187 +9 |
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
SunRunAway
pushed a commit
to SunRunAway/tidb
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There is a potential goroutine leak found here:
What is changed and how it works?
https://github.com/pingcap/tidb/compare/master...tiancaiamao:leak?expand=1#diff-7492d01b7aac81533194642850a45b8eL103
This line only listen for one exit condition.
If multiple error arrive and caller call
Close, without callingselectResult.Next()any more,nobody would drain from
r.resultsso the fetch goroutine blocks sending here forever (leak).I'm not quite sure that's the case, but this tiny refactor would make the code more robust.
Check List
Tests